I just noticed that the display type list was in a very weird order.
On the plus side, I think this makes more sense (and of course the sorting is local / i18n aware)
On the negative side, I guess the order in screenshots might not match for users with different language translations.
Thoughts before I merge?
Sounds good to me
Given the language already doesn’t match in screenshots, I don’t think it’s the end of the world.
I guess ideally once the manual is up to date we would look at putting it on the weblate platform too?
While you’re looking at the code for the display types list though, there is one other thing on my list:
I think it’s quite confusing for (particularly new) users to have options in that list that don’t do anything when toggled, because the user can’t tell whether truly nothing is happening or if they just can’t see the change. It also prevents them from working out what each display type actually is.
Indeed, I found the display types list quite confusing when I started using Avogadro.
Since the enabled/disabled status of checkboxes in Qt is separate from the checked/unchecked status, can we maybe disable display types when they are not currently relevant? E.g. crystal lattice is disabled until a crystal is loaded/created, surfaces are disabled until a surface is generated, dipole moment is disabled until there’s a dipole to depict. That way, whenever the user is able to toggle something, there will be a visible result.
The same default selection can be checked, that’s fine, if they’re checked but disabled they won’t be interpreted as active anyway.
As long as there’s interest, yes.
Good point. For a few of these, it shouldn’t be too hard to enable / disable. I’ll have to do a bit of testing as far as potential performance hits (e.g., these would be listening for molecular changes).
Fair. I was initially thinking more the other way round – that the burden of responsibility is on the respective features to send the signal to a slot to en/disable the display type – but maybe that’s more complex/bug-prone.