Problem with Gerrit

Development
1

Hi,

I pushed a patch to gerrit but it doesn’t show up on the webpage. When
I try to push it again it says there is no Change-Id so I think the
patch was uploaded correctly. Any ideas what might have gone wrong?

Thanks in advance,
Tim

2

Hi Tim,

On Sun, Mar 18, 2012 at 11:45 AM, Tim Vandermeersch
tim.vandermeersch@gmail.com wrote:

Hi,

I pushed a patch to gerrit but it doesn’t show up on the webpage. When
I try to push it again it says there is no Change-Id so I think the
patch was uploaded correctly. Any ideas what might have gone wrong?

Since we switched to topic based review we need to have a Change-Id
line as the final line in the commit message (I have been looking at
whether we can relax that). The setup for development script contains
instructions for downloading the local hook that will add that
automatically for you,

http://avogadro.openmolecules.net/wiki/Working_with_Gerrit

You can add the line to your last commit by running git commit
–amend, if you downloaded the local hook it will simply append it for
you once you save and close.

Let me know if you are still having trouble - I would like to automate
the local hook stuff soon to make this simpler.

Marcus

3

Hi,

On Sun, Mar 18, 2012 at 5:08 PM, Marcus D. Hanwell
mhanwell@gmail.com wrote:

Hi Tim,

On Sun, Mar 18, 2012 at 11:45 AM, Tim Vandermeersch
tim.vandermeersch@gmail.com wrote:

Hi,

I pushed a patch to gerrit but it doesn’t show up on the webpage. When
I try to push it again it says there is no Change-Id so I think the
patch was uploaded correctly. Any ideas what might have gone wrong?

Since we switched to topic based review we need to have a Change-Id
line as the final line in the commit message (I have been looking at
whether we can relax that). The setup for development script contains
instructions for downloading the local hook that will add that
automatically for you,

http://avogadro.openmolecules.net/wiki/Working_with_Gerrit

You can add the line to your last commit by running git commit
–amend, if you downloaded the local hook it will simply append it for
you once you save and close.

Let me know if you are still having trouble - I would like to automate
the local hook stuff soon to make this simpler.

Once I installed the hook and did git gerrit-push it appeared in gerrit.

Thanks,
Tim

Marcus