Is open recent option in file not yet implemented?

Kiran_Vasave · December 6, 2023, 8:46am

If not can i work on it?

ghutchis · December 6, 2023, 2:24pm

I’m confused. If I go to the File menu, is there not an “Open Recent” submenu?

Kiran_Vasave · December 6, 2023, 2:27pm

@ghutchis it is there but it is not working.I assumed that Open Recent will open the recently saved file .I dont know if my assumption is correct.

ghutchis · December 6, 2023, 2:40pm

I can’t say I’ve checked in detail. The code is here:

github.com

OpenChemistry/avogadroapp/blob/ba539c5ff9c5b723c10654870b663f8dc5ecc517/avogadro/mainwindow.cpp#L1379


      
                FileFormatDialog::findFileFormat(this, tr("Select file reader"), fileName,
                                                 FileFormat::File | FileFormat::Read);
          
              if (!openFile(fileName, format ? format->newInstance() : nullptr)) {
                MESSAGEBOX::information(this, tr("Cannot open file"),
                                        tr("Can't open supplied file %1").arg(fileName));
              }
            }
          }
          
          void MainWindow::updateRecentFiles()
          {
            m_recentFiles.removeDuplicates();
            while (m_recentFiles.size() > 10)
              m_recentFiles.removeLast();
          
            int i = 0;
            foreach (const QString& file, m_recentFiles) {
              QFileInfo fileInfo(file);
              QAction* recentFile = m_actionRecentFiles[i++];
              recentFile->setText(fileInfo.fileName());

Kiran_Vasave · December 6, 2023, 2:43pm

cool i will look into it.

Thomas · December 6, 2023, 9:24pm

@Kiran_Vasave The functionality is present and functional (Linux AppImage 1.98.1, fetched November 29th).

ghutchis · December 6, 2023, 9:55pm

It’s been present since the beginning. I don’t know if it’s updating in quite the way @Kiran_Vasave wants … I can’t say I pay much attention to it.