If not selected any location while saving the file the app crashes

Kiran_Vasave · February 25, 2024, 7:43am

[Bug] :If no location is selected while saving a file the app crashes

opened 07:41AM - 25 Feb 24 UTC

**Avogadro version: (please complete the following information from the About bo…x):** - Avogadrolibs: 1.99.0 - Qt: (e.g., 5.9.5) **Desktop version: (please complete the following information):** - OS: Ubuntu - Version :23.10 **Describe the bug** App carshes when you dont select the location in which you want to save the file . **To Reproduce** Steps to reproduce the behavior: 1. Go to **save** menu option .(You can recreate this bug with **save as** also) ![Screenshot from 2024-02-25 12-46-37](https://github.com/OpenChemistry/avogadrolibs/assets/134409422/e86a25aa-b46a-4729-93e5-7fd83cbb413d) 2. Click on **Save** or **Save As** option . A window will pop up for selecting the location. ![screenshot](https://github.com/OpenChemistry/avogadrolibs/assets/134409422/c9fe393e-f37a-4402-94d0-e4b6e4288153) 3.Now dont specify any location just exit from the screen shown in above picture.(Basically press the cancel button on the top left corner) ![Screenshot from 2024-02-25 12-47-25](https://github.com/OpenChemistry/avogadrolibs/assets/134409422/85fbb143-4176-426d-baea-18474f8d68fe) 4. The App will crash . 5. Console output is given in the picture attached below. ![Screenshot from 2024-02-25 12-48-42](https://github.com/OpenChemistry/avogadrolibs/assets/134409422/57705886-a741-4c50-8b97-03e83031dbbe) **Expected behavior** App should not crash **Additional context** Assert statement in the file location given in the console leads to this line. ![Screenshot from 2024-02-25 12-52-52](https://github.com/OpenChemistry/avogadrolibs/assets/134409422/7eae57ee-d615-452f-8bf6-ab244840cbc1)

Kiran_Vasave · February 25, 2024, 7:57am

I can recreate this bug in windows also.

Thomas · February 25, 2024, 4:40pm

With the AppImage for Linux downloaded today (packaged 2024-02-24), I don’t replicate your observation (Linux Debian 13/trixie).

matterhorn103 · February 25, 2024, 5:33pm

With the AppImage I get an error message within Avogadro and no crash, but the version I compiled myself it crashes with exactly the same thing printed to the console as @Kiran_Vasave reports.

Perhaps also of relevance is that the AppImage doesn’t use the native file picker on my system.

Ineluki · March 1, 2024, 10:35am

Bug confirmed in Windows 10 with today’s nightly build.

ghutchis · March 3, 2024, 3:22am

This is fixed:

github.com/OpenChemistry/avogadroapp

Fix crash when no selection is made when saving files

OpenChemistry:master ← ghutchis:fix-save-empty-crash

opened 03:21AM - 03 Mar 24 UTC

ghutchis

+4 -1

Fixes #479 Developer Certificate of Origin Version 1.1 Copyright (C) 2004…, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

system · March 6, 2024, 3:22am

This topic was automatically closed 3 days after the last reply. New replies are no longer allowed.