Does or doesn't Molecule maintain its own vector of atom pointers?

Hi,

in Molecule there’s a member vector _vatom. At first, I thought it meant that
Molecule maintained its own vector of atom pointers. But then I realized that
it seems that it’s never being filled with the actual atom pointers, right??
So should we remove the _vatom member (and then I guess _vbond too) ?

Other than that, I’m moving Molecule’s data to a d-pointer, moving Primitive’s
d-pointer to being private (as it should), and if we eventually find that
it’s not good to have 2 d-pointers in a inheritance tree, well this is a
classical issue and Qt provides ways to deal with that, with the macros Q_D
and Q_DECLARE_PRIVATE.

http://techbase.kde.org/Policies/Library_Code_Policy#Shared_D-Pointers

Cheers,
Benoit

Oh boy.

(Thu, Mar 15, 2007 at 09:16:54AM +0100) Benoît Jacob jacob@math.jussieu.fr:

Hi,

in Molecule there’s a member vector _vatom. At first, I thought it meant that
Molecule maintained its own vector of atom pointers. But then I realized that
it seems that it’s never being filled with the actual atom pointers, right??
So should we remove the _vatom member (and then I guess _vbond too) ?

So, i put those _vatom and _vbond things in there so that they would
overwrite the original definitions in OBMol which were vector<OBAtom *>
and vector<OBBond *>. But i did this right at the beginning of my C++
development career. It’s probably not doing anything but that’s one
situation where i have no clue. If anythign they can just be removed.

Other than that, I’m moving Molecule’s data to a d-pointer, moving Primitive’s
d-pointer to being private (as it should), and if we eventually find that
it’s not good to have 2 d-pointers in a inheritance tree, well this is a
classical issue and Qt provides ways to deal with that, with the macros Q_D
and Q_DECLARE_PRIVATE.

http://techbase.kde.org/Policies/Library_Code_Policy#Shared_D-Pointers

ok.


Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net’s Techsay panel and you’ll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV


Avogadro-devel mailing list
Avogadro-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/avogadro-devel