Moin
I just had a look how KDE 4.1 is doing this “setting debug flags” stuff. They
are doing it in a way more complex and probably better way. (see attached
CMakeLists.txt).
I copied their version in our CMakeLists.txt for you to have a look at it. I
think we should move Benoits if(RELEASE_MODE) around the first
if(CMAKE_COMPILER_IS_GNUCXX).
That would result in the attached diff.
The third option is: Let our CMakeLists.txt as it is.
Carsten
Moin (do you have a variant for the afternoon?? “Chmittag”???)
Just letting you know that I don’t have any firm opinion on these matters and
that the quick changes that I brought were just a proof-of-concept. I’m glad
to have you looking more seriously into these matters!
Also let me take this occasion to reply to what you wrote on #kalzium:
bjacob: I wonder if it makes sense to update the avogadro code now
reason: then the new api is already in it, just not as a real lib
Honestly I don’t think that’s useful. You should go ahead and make kalzium
depend directly on libavogadro trunk. Just, make sure to edit the cmake stuff
to disable avogadro-dependent parts of Kalzium unless a recent svn version of
libavogadro is found. This way, you don’t break compilation for most people
building kde trunk, you just temporarily disable a feature.
Cheers,
Benoit
On Sunday 16 March 2008 13:33:07 Carsten Niehaus wrote:
Moin
I just had a look how KDE 4.1 is doing this “setting debug flags” stuff.
They are doing it in a way more complex and probably better way. (see
attached CMakeLists.txt).
I copied their version in our CMakeLists.txt for you to have a look at it.
I think we should move Benoits if(RELEASE_MODE) around the first
if(CMAKE_COMPILER_IS_GNUCXX).
That would result in the attached diff.
The third option is: Let our CMakeLists.txt as it is.
Carsten