Cancelling SMILES import still builds molecule

brockdyer03 · February 14, 2025, 3:44pm

Environment Information

Avogadro version: 1.100.0-7-gac3f38f (Nightly from today)
Operating system and version: Windows 11 Pro 23H2

Expected Behavior

Hitting cancel after Build>Insert>SMILES should close window and do nothing

Actual Behavior

The molecule still gets built.

Steps to Reproduce

Use Build>Insert>SMILES, put in a SMILES, c(C(F)(F)F)1nn[nH]c1C(F)(F)F for example, and hit cancel

ghutchis · February 14, 2025, 8:45pm

If only all bugs were so quick to fix.

github.com/OpenChemistry/avogadrolibs

Make sure to cancel "Insert SMILES"

master ← ghutchis:fix-cancel-build-smiles

opened 08:44PM - 14 Feb 25 UTC

ghutchis

+20 -5

Also save the last SMILES for re-use Developer Certificate of Origin Version… 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.