Hi Marcus,
I see very strange diff between patch sets 1 and 2
http://review.avogadro.openmolecules.net:8080/#change,293
Is it a bug in Gerrit? What have actually been changed?
–
Regards,
Konstantin
On 16 November 2010 08:28, Konstantin Tokarev annulen@yandex.ru wrote:
Hi Marcus,
I see very strange diff between patch sets 1 and 2
http://review.avogadro.openmolecules.net:8080/#change,293Is it a bug in Gerrit? What have actually been changed?
It is because it was cherry-picked to a whole different branch - from
1.0 to master. The inter-patch diff in that case makes little sense. I
didn’t think it would show the “new” patch set, which was just the
original patch cherry-picked, and with the Change-Id line inserted so
it was clear it was the same commit.
git show afca60c765a786e81477aeabf4bf7b1e0c27fcaf
That shows the commit, and what it changes, in Avogadro. The commits
in Avogadro are all that really matters, and that is where you should
always look for more details/clarity.
Marcus