Avogadro2 1.98.1,App Crashes When I click on one of the options available in select menu

Kiran_Vasave · December 3, 2023, 6:27pm

When I clicked on **Create New layer from Selection ** from select menu the app crashes .

I ran the application on windows 11 version 10.0.2261 .

Kiran_Vasave · December 3, 2023, 6:29pm

Is this a bug or problem with my system ?

ghutchis · December 3, 2023, 6:38pm

It’s definitely a bug. Just got it to crash on my Mac. Clearly it wasn’t tested with no molecule / selection.

Kiran_Vasave · December 3, 2023, 7:04pm

Should i work on it? this menu application is in which repo the library one or the app one
?

ghutchis · December 3, 2023, 7:21pm

If you want to give it a try, the appropriate code would be here:

github.com

OpenChemistry/avogadrolibs/blob/219b47d3b54d292a9de8578caf91c27e9e8f878d/avogadro/qtplugins/select/select.cpp#L542


      
          void Select::invertSelection()
          {
            if (m_molecule) {
              for (Index i = 0; i < m_molecule->atomCount(); ++i)
                m_molecule->undoMolecule()->setAtomSelected(
                  i, evalSelect(!m_molecule->atomSelected(i), i), tr("Invert Selection"));
              m_molecule->emitChanged(Molecule::Atoms);
            }
          }
          
          void Select::createLayerFromSelection()
          {
            if (!m_molecule)
              return;
          
            QtGui::RWMolecule* rwmol = m_molecule->undoMolecule();
            rwmol->beginMergeMode(tr("Change Layer"));
            Molecule::MoleculeChanges changes =
              Molecule::Atoms | Molecule::Layers | Molecule::Modified;
          
            auto& layerInfo = Core::LayerManager::getMoleculeInfo(m_molecule)->layer;

Kiran_Vasave · December 3, 2023, 7:22pm

i will give it a try thx

Kiran_Vasave · December 4, 2023, 9:43am

@ghutchis can you tell whats the exact function of the Create New Layer from Selection

Kiran_Vasave · December 4, 2023, 9:52am

In documentation of avogadro 2 theres no mention of this option
instead there is Add named Selection

matterhorn103 · December 4, 2023, 10:40am

A new layer is created and any selected atoms are moved to it. So if you draw two ethane molecules and select one, then click that option, you will then have two layers, with one ethane molecule in each.

A faster way of adding a layer, then selecting an object, then changing its layer from the Selection panel.

Kiran_Vasave · December 4, 2023, 10:51am

thanks @matterhorn103

Kiran_Vasave · December 4, 2023, 5:02pm

@matterhorn103 @ghutchis can you clarify my doubt

suppose i didnt select any atom then i shouldnt create a new layer right when i press
create new layer from Selection

ghutchis · December 4, 2023, 5:05pm

I mean, the app should never crash.

Kiran_Vasave · December 4, 2023, 5:14pm

@ghutchis I have updated code should i create a PR. you can review it .

ghutchis · December 4, 2023, 5:19pm

Of course. PRs always welcome.