Avogadro 2 1.98.1 Select Menu Select By Atom index crashes the app

Kiran_Vasave · December 4, 2023, 3:29pm

To reproduce this bug type some arbitary atom index which is not present in the current atoms.
The System crashes!
This bug is similar to the bug of **Create New layer from Selection ** crash bug.

ghutchis · December 4, 2023, 3:39pm

Thanks. Yeah, that’s because you don’t have any atoms.

Should be some easy bugs to fix - those methods should check to see if the molecule has atoms and if not, just return.

BTW, I definitely appreciate the testing / bug reporting. It’s always hard to come at an app with “I’m going to try everything”

ghutchis · December 4, 2023, 4:54pm

Okay, here’s a fix:

github.com/OpenChemistry/avogadrolibs

Fix potential crashes in selection commands

OpenChemistry:master ← ghutchis:stop-selection-crashes

opened 04:54PM - 04 Dec 23 UTC

ghutchis

+21 -9

Check that molecules have atoms before doing something Hat tip to Kiran_Vasave o…n the forum Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.