Krazy on Avogadro

No, this is not a grammar-typo :slight_smile: Krazy is a collection of
code-and-api-checking scripts KDE uses. It finds many issues like
missing api-docs, wrong/missing copyrights, styleissues, missing const
references and so on.

I would like to enable Krazy for Avogadro. If you don’t mind I will
copy a version of Krazy to avos SVN and run it from time to time.

Carsten

After discussion on IRC I just added a couple of demo/test molecules
to trunk/testfiles/

I will add Krazy as trunk/krazy.

Carsten

On May 18, 2007, at 12:27 PM, Carsten Niehaus wrote:

I would like to enable Krazy for Avogadro. If you don’t mind I will
copy a version of Krazy to avos SVN and run it from time to time.

That would be great!

Is there any way I can get a copy for Open Babel too? I’m sure it’ll
turn up all sorts of issues. By the way, we should probably run that
script to minimize header #includes over Avogadro and libavogadro.
I’m sure there are many un-needed #include statements.

Thanks,
-Geoff

2007/5/18, Geoffrey Hutchison geoff.hutchison@gmail.com:

I would like to enable Krazy for Avogadro. If you don’t mind I will
copy a version of Krazy to avos SVN and run it from time to time.

That would be great!

I will try in ~1h.

Is there any way I can get a copy for Open Babel too? I’m sure it’ll
turn up all sorts of issues.

Of course, Krazy is to be found in KDESDK and is under a free licence.
If my “port” to Avo is simple I bet it takes only 10 minutes or so to
make it work on OB.

By the way, we should probably run that
script to minimize header #includes over Avogadro and libavogadro.
I’m sure there are many un-needed #include statements.

Yes, I will try that soon as well. That script is also in kdesdk.

Carsten

Moin

I just figured out how Krazy works. You do something like this:

export PATH=$PATH:/usr/local/Krazy/bin
krazy --export html --explain * > issues.html

That means we get one issues.html per directory. I just commited a
file in trunk/avogadro/src with many found issues. Lets fix some :slight_smile:

Question: Should I add one issues.html per directory or do you want me
to have stuff like “avogadro-src-exenstions.html” in trunk/krazy?

Carsten

PS: Geoff: Currently krazy’ing OB 2.1.

Mmh, what about placing it here:

http://avogadro.sourceforge.net/krazy/libavo-src.html

Carsten