Gerrit updates and replication to other locations

Hi,

I wanted to let you all know that Gerrit was upgraded recently, it
appears that there were a few teething issues with the replication
process after this update. These are now resolved, and all new changes
should be replicated automatically. You should review code, and once
it is approved and verified it can be submitted. You should only
submit topics, and that will create an appropriate merge commit, which
will be pushed to replicated locations (normally within minutes).

For the remaining commits, they can also be submitted as commits and
merge commits should appear as expected. No one should be pushing
directly to master anymore, if you have problems please let me know so
that I can get them resolved.

Marcus

submit topics, and that will create an appropriate merge commit, which
will be pushed to replicated locations (normally within minutes).

So does that mean that we should review a whole topic branch and then submit the tip of the branch?

I’m looking at things like:
http://review.source.kitware.com/#/c/3549/

Thanks,
-Geoff

On Sun, Jan 22, 2012 at 2:54 PM, Geoff Hutchison
geoff.hutchison@gmail.com wrote:

submit topics, and that will create an appropriate merge commit, which
will be pushed to replicated locations (normally within minutes).

So does that mean that we should review a whole topic branch and then submit the tip of the branch?

I’m looking at things like:
http://review.source.kitware.com/#/c/3549/

That is an individual change, and until we work through all of these
they should be submitted when they are approved (as I did) and they
will be merged correctly. I was referring to things like,

http://review.source.kitware.com/#/t/9/

This is a topic which has one commit, reviewing the individual commits
and then submitting the entire topic from this page once the topic is
ready to be merged. Open topics can be found by going to All -> Topics
-> Open on the top navigation bar. A topic has a list of all commits
that are part of the topic, and you can extend topics (add new
commits) or drop commits from topics (causing individual changes to be
marked as abandoned).

The testing scripts I have will test the topic tips, and I will be
bringing dashboard resources online to automate this testing of the
topic tips soon with Kyle and Dave Cole’s help. Let me know if
anything is unclear, I will finish up the wiki pages explaining how
all of this works and provide pointers there too.

Marcus