Hi Carsten,
On Tue, Mar 22, 2011 at 3:27 PM, Carsten Niehaus cniehaus@gmx.de wrote:
As soon as you have a windows-binary for me to test I will test your code
and report back.
I’ve built and uploaded a window installer here:
http://avogadro.openmolecules.net/nightly/win/crystallography-preview/Avogadro-1.1.0-win32.exe
Dave
Am 22.03.2011 23:41, schrieb David Lonie:
Hi Carsten,
On Tue, Mar 22, 2011 at 3:27 PM, Carsten Niehauscniehaus@gmx.de wrote:
As soon as you have a windows-binary for me to test I will test your code
and report back.I’ve built and uploaded a window installer here:
http://avogadro.openmolecules.net/nightly/win/crystallography-preview/Avogadro-1.1.0-win32.exe
Dave
Works.
Comments:
1: P 1
2: P -1
3: P 1 2 1
I don’t like two things about this: First, in the UI it then reads P 1
(1), IMHO it should also be 1: P 1 (consistency). Second: Why don’t you
write
Cubic: P 1
Cubic: P -1
Cubic: P 1 2 1
Orthorombic: …
Perhaps you could even add a second QComboBox with Triclinic, monoclic,
Orthorombic etc and then remove all other groups from the second
combobox. That would make the list way shorter. Perhaps its just me
but I find that list not exactly easy to parse 
Carsten
Hi Carsten,
On Thu, Mar 24, 2011 at 12:36 PM, Carsten Niehaus cniehaus@gmx.de wrote:
- I’d add some tooltips
The only place that tooltips can be added are the editor dockwidgets,
but I think those are rather self-explanitory. If something is unclear
in the editor interfaces I can add tooltips, but I think I’m too close
to this project to see what needs clarification on those.
Some of the menu items should have additional information available,
but the only way to do that in Qt (that I’m aware of, at least) is
through statusbar tips, but the avogadro mainwindow does not use a
status bar. I don’t see why not, though. I can enable the statusbar
and add tips for the less obvious actions.
Does anyone object to the status bar being shown, or know of a reason
why it isn’t already shown?
- I get a crash (read-error) when exiting Avogadro (Windows XP). I have no
idea how to get a backtrace in Windows.
Hmm, it exits cleanly here every time. Does this happen every time you
close Avogadro? If not, can you post steps to reproduce this crash?
- cannot select nm for the lenght (only angstrom and bohr).
This was my fault – I built an old version of the extension. I’ve
rebuilt the latest code and pushed it to the same link:
http://avogadro.openmolecules.net/nightly/win/crystallography-preview/Avogadro-1.1.0-win32.exe
- No matter which spacegroup I set I see no difference beside the
debug-message changing in the top left corner.
What other changes would you like to see? Right now, setting the space
group is really only useful for “Fill Unit Cell” operations.
- I think that you shouldn’t use a this QComboBox for those spacegroups
(“Set Spacegroup”-menu). Right now it looks like this:1: P 1
2: P -1
3: P 1 2 1I don’t like two things about this: First, in the UI it then reads P 1 (1),
IMHO it should also be 1: P 1 (consistency). Second: Why don’t you writeCubic: P 1
Cubic: P -1
Cubic: P 1 2 1
Orthorombic: …Perhaps you could even add a second QComboBox with Triclinic, monoclic,
Orthorombic etc and then remove all other groups from the second combobox.
That would make the list way shorter. Perhaps its just me but I find that
list not exactly easy to parse
I fully agree, and this is something I’ve been thinking about. The
enormous combobox is just a placeholder for something much cooler 
Geoff suggested this sort of interface a while ago:
http://avogadro.openmolecules.net/wiki/CrystalMaker
I’m not a big fan of that specific interface (what if you wanted to
see all monoclinic spacegroups but don’t know the centering type?),
but I want to add a new selection dialog. I’m thinking a list widget
that has all spacegroups in it and a set of combo boxes for selecting
the lattice, centering, types of operations, etc. Changing the
comboboxes would filter the list of spacegroups so that only the
spacegroups that meet the criteria are displayed. This will probably
take a while to write, though.
Dave