CMake FindOpenBabel2.cmake

For the CMake “FindOpenBabel2.cmake” file there is now a variable to
test the version of OpenBabel. However, if I do my cmake manually such
as:

cmake -DCMAKE_INSTALL_PREFIX=/var/tmp/usr
-DEIGEN_INCLUDE_DIR=/var/tmp/usr/include
-DOPENBABEL2_INCLUDE_DIR=/var/tmp/usr/include/openbabel-2.0
-DOPENBABEL2_LIBRARIES=/var/tmp/usr/lib/libopenbabel.so.2 …

It will give me an error because OPENBABEL_MINI_FOUND is not defined.
Now, I realized you want to make sure if someone did an “svn up” that
they are now updating their OpenBabel. I believe there is no way to
have both solutions.

If we keep it as-is could we please change it to OPENBABEL2_VERSION or
OPENBABEL2_VERSION_MET or at least something with the prefix OPENBABEL2_

Else, could we just take the “AND OPENBABEL_MINI_FOUND” off the first if
statement. Since it’s a Kalzium thing too it would be nice to have some
sort of resolution.

Not a huge deal but recent email reminded me of this same issue I had.


Donald

Moin

On sunday I synced Avos FindOB.cmake with the one in kdeedu. There it works and of course I also tested this patch on my machine. I asked on IRc for others to test and think soc confirmed it worked…

Sorry if I broke build… No idea why it works on my machine and works for kdeedu.

Carsten

GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS.
Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

It works in avo too unless I ‘manually’ specify the
OPENBABEL2_INCLUDE_DIR and OPENBABEL2_LIBRARIES in which case it also
requires me to specify OPENBABEL_MINI_FOUND. Didn’t really break
anything.

(Thu, Dec 06, 2007 at 08:19:03AM +0100) Carsten Niehaus CNiehaus@gmx.de:

Moin

On sunday I synced Avos FindOB.cmake with the one in kdeedu. There it works and of course I also tested this patch on my machine. I asked on IRc for others to test and think soc confirmed it worked…

Sorry if I broke build… No idea why it works on my machine and works for kdeedu.

Carsten

GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS.
Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail