O.K. Can’t reproduce it either using your branch (just cloned from “git://github.com/annulen/avogadro.git”).
All includes are created where they should in libavogadro/include.
The trouble is that I usually clone/pull from “git://github.com/cryos/avogadro.git”.
There must be something screwed up beetween the two repos for in this case
the error is completely reproducable, at least for me.
Regards,
Louis
Le 15 mai 2010 à 11:49, Konstantin Tokarev a écrit :
On Thu, 13 May 2010 18:46:14 +0200
Louis Ricard louis.ricard@polytechnique.edu wrote:
A few more observations.
On the Mac, the qperiodictable and qplotwidget include directories
are created at the system root (maybe because the superuser has admin
wrights). It looks like the corresponding CMakeLists.txt(?) thinks
that “libavogadro_BINARY_DIR” is not defined resulting in
“mkdir /include/…” Moving /include/* to build/libavogadro/include
and re-running cmake WHITOUT deleting the build directory allow
successful compilation (?).
So I revisited my CentOS build. As I told previously, the two
includes are NOT created in libavogadro/include. But qperiodictable
and qplotwidget includes were present in /usr/local/include from
previous build. So, I deleted these and also avogadro include
directories in /usr/local/include and ran a fresh cmake in my build
directory. Now, build fails.
Can’t reproduce. Works for me as it should.
–
Regards,
Konstantin
Avogadro-devel mailing list
Avogadro-devel@lists.sourceforge.net
avogadro-devel List Signup and Options
On Sat, 15 May 2010 13:08:08 +0200
Louis Ricard louis.ricard@polytechnique.edu wrote:
O.K. Can’t reproduce it either using your branch (just cloned from
“git://github.com/annulen/avogadro.git”). All includes are created
where they should in libavogadro/include.
The trouble is that I usually clone/pull from
“git://github.com/cryos/avogadro.git”. There must be something
screwed up beetween the two repos for in this case the error is
completely reproducable, at least for me.
Regards,
Louis
Strange - those changes were merged into cryos/master. Probably we
should analyze diff between two trees
–
Regards,
Konstantin
On Sat, 15 May 2010 15:32:42 +0400
Konstantin Tokarev annulen@yandex.ru wrote:
On Sat, 15 May 2010 13:08:08 +0200
Louis Ricard louis.ricard@polytechnique.edu wrote:
O.K. Can’t reproduce it either using your branch (just cloned from
“git://github.com/annulen/avogadro.git”). All includes are created
where they should in libavogadro/include.
The trouble is that I usually clone/pull from
“git://github.com/cryos/avogadro.git”. There must be something
screwed up beetween the two repos for in this case the error is
completely reproducable, at least for me.
Regards,
Louis
Strange - those changes were merged into cryos/master. Probably we
should analyze diff between two trees
I’ve found what causes this issue - somebody placed periodictable and
plotwidget in CMakeLists before libavogadro while they must go after
–
Regards,
Konstantin
Oups. Replied to wrong message.
L.
Le 15 mai 2010 à 14:31, Konstantin Tokarev a écrit :
On Sat, 15 May 2010 15:32:42 +0400
Konstantin Tokarev annulen@yandex.ru wrote:
On Sat, 15 May 2010 13:08:08 +0200
Louis Ricard louis.ricard@polytechnique.edu wrote:
O.K. Can’t reproduce it either using your branch (just cloned from
“git://github.com/annulen/avogadro.git”). All includes are created
where they should in libavogadro/include.
The trouble is that I usually clone/pull from
“git://github.com/cryos/avogadro.git”. There must be something
screwed up beetween the two repos for in this case the error is
completely reproducable, at least for me.
Regards,
Louis
Strange - those changes were merged into cryos/master. Probably we
should analyze diff between two trees
I’ve found what causes this issue - somebody placed periodictable and
plotwidget in CMakeLists before libavogadro while they must go after
–
Regards,
Konstantin
Avogadro-devel mailing list
Avogadro-devel@lists.sourceforge.net
avogadro-devel List Signup and Options
On Tuesday 11 May 2010 14:36:19 Louis Ricard wrote:
Hi all
Using latest trunk sources in Mac Snow Leopard, I get the following error:
I think this is another area where the dashboards could be very helpful. I
may be getting a Mac of my very own in the next month or so, but until then
can’t test directly. You do need to be careful about having empty variables.
The current set up is a little strange too - the avogadro include directory
used to be just libavogadro includes, now it has two others in its namespace
that have been split out. So there is some strange tree walking going off.
What we should probably do is create include directories for qperiodictable
and qplotwidget in their own built trees, then add those to the compilers
include directories using CMake’s include_directories function. Then the
headers would be closer to their source/build, and would form independent
units.
I can look into this if no one gets there soon, there are a few spots where
things could do with being fixed up a little. I also think that setting up
external projects could be very useful as it provides a very clear separation
and essentially just glues the dependent projects together with no need for
changes in any of the projects (each has their own CMakeCache.txt).
Thanks,
Marcus
The current set up is a little strange too - the avogadro include directory
used to be just libavogadro includes, now it has two others in its namespace
that have been split out. So there is some strange tree walking going off.
What we should probably do is create include directories for qperiodictable
and qplotwidget in their own built trees, then add those to the compilers
include directories using CMake’s include_directories function. Then the
headers would be closer to their source/build, and would form independent
units.
Of course, yes. I’ve placed them into libavogadro as a part of step-by-step separation
I can look into this if no one gets there soon, there are a few spots where
things could do with being fixed up a little. I also think that setting up
external projects could be very useful as it provides a very clear separation
and essentially just glues the dependent projects together with no need for
changes in any of the projects (each has their own CMakeCache.txt).
Simple superproject is fine too. Actually, current Avogadro top-level CMakeLists.txt serves a superpackage of libavogadro, libqplotwidget, libqperiodictable and avogadro-app
–
Regards,
Konstantin
Hi all.
Will someone correct this someday?
“# tell cmake to process CMakeLists.txt in that subdirectory
add_subdirectory(plotwidget)
add_subdirectory(periodictable)
add_subdirectory(libavogadro)
add_subdirectory(avogadro)
add_subdirectory(doc)”
to read:
“# tell cmake to process CMakeLists.txt in that subdirectory
add_subdirectory(libavogadro)
add_subdirectory(avogadro)
add_subdirectory(plotwidget)
add_subdirectory(periodictable)
add_subdirectory(doc)”
like Konstantin pointed out some days ago.
In avogadro/CMakeLists.txt at master · cryos/avogadro · GitHub
Louis
Le 16 mai 2010 à 23:20, Marcus D. Hanwell a écrit :
On Tuesday 11 May 2010 14:36:19 Louis Ricard wrote:
Hi all
Using latest trunk sources in Mac Snow Leopard, I get the following error:
I think this is another area where the dashboards could be very helpful. I
may be getting a Mac of my very own in the next month or so, but until then
can’t test directly. You do need to be careful about having empty variables.
The current set up is a little strange too - the avogadro include directory
used to be just libavogadro includes, now it has two others in its namespace
that have been split out. So there is some strange tree walking going off.
What we should probably do is create include directories for qperiodictable
and qplotwidget in their own built trees, then add those to the compilers
include directories using CMake’s include_directories function. Then the
headers would be closer to their source/build, and would form independent
units.
I can look into this if no one gets there soon, there are a few spots where
things could do with being fixed up a little. I also think that setting up
external projects could be very useful as it provides a very clear separation
and essentially just glues the dependent projects together with no need for
changes in any of the projects (each has their own CMakeCache.txt).
Thanks,
Marcus
Avogadro-devel mailing list
Avogadro-devel@lists.sourceforge.net
avogadro-devel List Signup and Options
I’ve reverted that patch in my branch. Just wait until Geoff or Marcus will merge it 
18.05.10, 22:54, “Louis Ricard” Louis.RICARD@polytechnique.edu:
Hi all.
Will someone correct this someday?
“# tell cmake to process CMakeLists.txt in that subdirectory
add_subdirectory(plotwidget)
add_subdirectory(periodictable)
add_subdirectory(libavogadro)
add_subdirectory(avogadro)
add_subdirectory(doc)”
to read:
“# tell cmake to process CMakeLists.txt in that subdirectory
add_subdirectory(libavogadro)
add_subdirectory(avogadro)
add_subdirectory(plotwidget)
add_subdirectory(periodictable)
add_subdirectory(doc)”
like Konstantin pointed out some days ago.
In avogadro/CMakeLists.txt at master · cryos/avogadro · GitHub
Louis
Le 16 mai 2010 à 23:20, Marcus D. Hanwell a écrit :
On Tuesday 11 May 2010 14:36:19 Louis Ricard wrote:
Hi all
Using latest trunk sources in Mac Snow Leopard, I get the following error:
I think this is another area where the dashboards could be very helpful. I
may be getting a Mac of my very own in the next month or so, but until then
can’t test directly. You do need to be careful about having empty variables.
The current set up is a little strange too - the avogadro include directory
used to be just libavogadro includes, now it has two others in its namespace
that have been split out. So there is some strange tree walking going off.
What we should probably do is create include directories for qperiodictable
and qplotwidget in their own built trees, then add those to the compilers
include directories using CMake’s include_directories function. Then the
headers would be closer to their source/build, and would form independent
units.
I can look into this if no one gets there soon, there are a few spots where
things could do with being fixed up a little. I also think that setting up
external projects could be very useful as it provides a very clear separation
and essentially just glues the dependent projects together with no need for
changes in any of the projects (each has their own CMakeCache.txt).
Thanks,
Marcus
Avogadro-devel mailing list
Avogadro-devel@lists.sourceforge.net
avogadro-devel List Signup and Options
–
Regards,
Konstantin
Яндекс.Почта. Письма есть. Спама - нет. http://mail.yandex.ru/nospam/sign